This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Conversation
andresilva
force-pushed
the
andre/bump-version-0.6.5
branch
from
1de27a7 to
4dd0b2f
Compare
bkchr
approved these changes
Oct 30, 2019
gavofyork
pushed a commit
that referenced
this pull request
Oct 31, 2019
gavofyork
added a commit
that referenced
this pull request
Oct 31, 2019
* bump version to 0.6.6 (#516) * retry on gitlab system failures (#521) * retry on gitlab system failures * max is just 2 * Bump Substrate master (#522) * Bump substrate * Bump runtime version * Fix Configuration stuff * fix extract_proof return type * add ImOnline module as Authorship event handler
tomusdrw
pushed a commit
that referenced
this pull request
Mar 26, 2021
imstar15
pushed a commit
to imstar15/polkadot
that referenced
this pull request
Aug 25, 2021
* Propose bumping StringLimit to 64 bytes The StringLimit of 50 bytes is too short for useful hashes of different protocols: - When using IPFS, the hash is 46 bytes. With a protocol prefix and type prefix (IPFS vs IPNS) it becomes: `ipfs://ipfs/QmPK1s3pNYLi9ERiq3BDxKa4XosgWwFRQUydHUtz4YgpqB` or 59 bytes. - On arweave, the hash is 43 bytes. Prefixed with just `arweave://` bumps it up to 53: `arweave://BNttzDav3jHVnNiV7nYbQv-GY0HQ-4XXsdkE5K9ylHQ`. - On Sia, with 46 char hashes, adding `sia://` as the protocol to use will bump it past 50: `sia://GACjmEWXmYF1N3Rc-PyjN304-8M0zOXHYzAXY9222xkGhA` (52) As such, we feel that 64 bytes is a reasonable minimum for the `StringLimit`. * Update lib.rs * Add different const for `UniquesStringLimit` Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.